From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39291)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VQg0N-000881-1n
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 12:07:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VQg0G-0002eH-Dg
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 12:07:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12046)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VQg0G-0002e6-51
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 12:07:20 -0400
Date: Mon, 30 Sep 2013 19:09:38 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130930160938.GA13918@redhat.com>
References: <1380452123-5989-1-git-send-email-mst@redhat.com>
	<1380452123-5989-2-git-send-email-mst@redhat.com>
	<20130930151056.32699e7f@nial.usersys.redhat.com>
	<20130930144050.GB22806@redhat.com>
	<CAFEAcA8Q3EWwL=fKgaYP-eYXR5aVJ1iMkTT71D=nEPmm+0OOiQ@mail.gmail.com>
	<20130930155044.GA10306@redhat.com> <52499F06.20903@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <52499F06.20903@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Mon, Sep 30, 2013 at 05:55:50PM +0200, Andreas F=E4rber wrote:
> Am 30.09.2013 17:50, schrieb Michael S. Tsirkin:
> > On Tue, Oct 01, 2013 at 12:10:52AM +0900, Peter Maydell wrote:
> >> On 30 September 2013 23:40, Michael S. Tsirkin <mst@redhat.com> wrot=
e:
> >>> diff --git a/include/qapi/error.h b/include/qapi/error.h
> >>> index 7d4c696..b85e996 100644
> >>> --- a/include/qapi/error.h
> >>> +++ b/include/qapi/error.h
> >>> @@ -13,14 +13,15 @@
> >>>  #define ERROR_H
> >>>
> >>>  #include "qemu/compiler.h"
> >>> +#include "qemu/typedefs.h"
> >>>  #include "qapi-types.h"
> >>>  #include <stdbool.h>
> >>>
> >>>  /**
> >>> - * A class representing internal errors within QEMU.  An error has=
 a ErrorClass
> >>> + * Error:
> >>> + * An object representing internal errors within QEMU.  An error h=
as a ErrorClass
> >>>   * code and a human message.
> >>>   */
> >>> -typedef struct Error Error;
> >>
> >> Does the process-doc-comments tool really cope with documentation co=
mments
> >> that are completely separate from the typedef like this?
> >>
> >> thanks
> >> -- PMM
> >=20
> > Do we care?
> > Downstreams don't seem to package it, most people probably use
> > editor tags anyway ...
> > If yes we can put this all in #if 0.
>=20
> Can we turn the typedef into just struct Error here? The doc comment ca=
n
> be applied to either.
>=20
> Andreas

It won't index Error typedef then though.

How does one run this process-doc-comments tool by the way?

> --=20
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn=
berg