From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQg0g-0008PV-I0 for qemu-devel@nongnu.org; Mon, 30 Sep 2013 12:07:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQg0Y-0002h3-CV for qemu-devel@nongnu.org; Mon, 30 Sep 2013 12:07:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQg0Y-0002gx-4K for qemu-devel@nongnu.org; Mon, 30 Sep 2013 12:07:38 -0400 Date: Mon, 30 Sep 2013 19:09:57 +0300 From: "Michael S. Tsirkin" Message-ID: <20130930160957.GB13918@redhat.com> References: <1380452123-5989-1-git-send-email-mst@redhat.com> <1380452123-5989-2-git-send-email-mst@redhat.com> <20130930151056.32699e7f@nial.usersys.redhat.com> <20130930144050.GB22806@redhat.com> <8738om1f95.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8738om1f95.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Peter Maydell , QEMU Developers , Gerd Hoffmann , Igor Mammedov , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= On Mon, Sep 30, 2013 at 05:49:26PM +0200, Markus Armbruster wrote: > Peter Maydell writes: > > > On 30 September 2013 23:40, Michael S. Tsirkin wrote: > >> diff --git a/include/qapi/error.h b/include/qapi/error.h > >> index 7d4c696..b85e996 100644 > >> --- a/include/qapi/error.h > >> +++ b/include/qapi/error.h > >> @@ -13,14 +13,15 @@ > >> #define ERROR_H > >> > >> #include "qemu/compiler.h" > >> +#include "qemu/typedefs.h" > >> #include "qapi-types.h" > >> #include > >> > >> /** > >> - * A class representing internal errors within QEMU. An error has a ErrorClass > >> + * Error: > >> + * An object representing internal errors within QEMU. An error has a ErrorClass > >> * code and a human message. > >> */ > >> -typedef struct Error Error; > > > > Does the process-doc-comments tool really cope with documentation comments > > that are completely separate from the typedef like this? > > Even if they do, I don't. What kind of error do you encounter?