From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55565)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VR0CR-0006mE-6e
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 09:41:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VR0CL-0006Su-9I
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 09:41:15 -0400
Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:46071)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VR0CK-0006Sg-VD
	for qemu-devel@nongnu.org; Tue, 01 Oct 2013 09:41:09 -0400
Received: by mail-wi0-f177.google.com with SMTP id cb5so5580292wib.10
	for <qemu-devel@nongnu.org>; Tue, 01 Oct 2013 06:41:07 -0700 (PDT)
Date: Tue, 1 Oct 2013 15:41:04 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20131001134104.GB23437@stefanha-thinkpad.redhat.com>
References: <cover.1380141614.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1380141614.git.jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 00/20] VHDX log replay and write support,
 .bdrv_create()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, Sep 25, 2013 at 05:02:45PM -0400, Jeff Cody wrote:
> 
> This patch series contains the initial VHDX log parsing, replay,
> write support, and image creation.
> 
> === v6 changes ===
> https://github.com/codyprime/qemu-kvm-jtc/tree/vhdx-write-v6-upstream
> 
> Rebased to latest qemu/master:
> 
> Patch 16/20: .bdrv_create() propagates Error, and bdrv_unref() used
>              instead of bdrv_delete().
> 
> Patch 17 & 18 are already included in another series:
>     [PATCH v3 0/3] qemu-iotests with sample images, vhdx test, cleanup
> 
> They are included here to provide a base for patches 19 & 20.  If the above
> series is applied before this series, then patches 17 and 18 can be ignored.
> 
> Patch 19/20: In qemu-io tests _make_test_img(), filter out vhdx-specific
>              options for .bdrv_create().
> 
> Patch 20/20: Add VHDX write test case to 064.

Sorry for the late review.  Feel free to poke Kevin or me if we're being
slow - the squeaky wheel gets the grease.

I left comments on a couple of the core journal and write patches.  It
looks pretty good overall.

How is the journal code tested?  IIUC the sample image file does not
have a dirty journal.  Please try to include an image that Hyper-V
created with a dirty journal so we can be sure flushing the journal
works.

Stefan