From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRMRQ-0006NW-O8 for qemu-devel@nongnu.org; Wed, 02 Oct 2013 09:26:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRMRG-000601-O0 for qemu-devel@nongnu.org; Wed, 02 Oct 2013 09:26:12 -0400 Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:60686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRMRG-0005zv-Ge for qemu-devel@nongnu.org; Wed, 02 Oct 2013 09:26:02 -0400 Received: by mail-wg0-f52.google.com with SMTP id m15so885640wgh.7 for ; Wed, 02 Oct 2013 06:26:01 -0700 (PDT) Date: Wed, 2 Oct 2013 14:26:35 +0200 From: Stefan Hajnoczi Message-ID: <20131002122635.GC12200@stefanha-thinkpad.redhat.com> References: <1378695482-29805-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1378695482-29805-2-git-send-email-xiawenc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378695482-29805-2-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V3 1/7] qcow2: restore nb_snapshots when fail in snapshot creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com On Mon, Sep 09, 2013 at 10:57:56AM +0800, Wenchao Xia wrote: > If it is not restored after qcow2_write_snapshots() fail, a core > dump will happen in bdrv_close() since access of invalid pointer. > > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) Good candidate for -stable. Please add: Cc: qemu-stable@nongnu.org