From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRLr7-00043c-EW for qemu-devel@nongnu.org; Wed, 02 Oct 2013 08:48:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRLr0-0001vY-Jb for qemu-devel@nongnu.org; Wed, 02 Oct 2013 08:48:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRLr0-0001vE-CI for qemu-devel@nongnu.org; Wed, 02 Oct 2013 08:48:34 -0400 Date: Wed, 2 Oct 2013 15:50:47 +0300 From: "Michael S. Tsirkin" Message-ID: <20131002125047.GA2650@redhat.com> References: <1380717694-13091-1-git-send-email-marcel.a@redhat.com> <1380717694-13091-2-git-send-email-marcel.a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1380717694-13091-2-git-send-email-marcel.a@redhat.com> Subject: Re: [Qemu-devel] [PATCH RFC v2 1/9] hw/core: Add interface to allocate and free a single IRQ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: kwolf@redhat.com, peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, anthony@codemonkey.ws, sw@weilnetz.de, jasowang@redhat.com, qemu-devel@nongnu.org, dkoch@verizon.com, keith.busch@intel.com, alex.williamson@redhat.com, kraxel@redhat.com, stefanha@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, afaerber@suse.de, ehabkost@redhat.com On Wed, Oct 02, 2013 at 03:41:26PM +0300, Marcel Apfelbaum wrote: > qemu_allocate_irq returns a single qemu_irq. > The interface allows to specify an interrupt number. > > qemu_free_irq frees it. > > Signed-off-by: Marcel Apfelbaum > --- > hw/core/irq.c | 16 ++++++++++++++++ > include/hw/irq.h | 7 +++++++ > 2 files changed, 23 insertions(+) > > diff --git a/hw/core/irq.c b/hw/core/irq.c > index 2078542..03c8cb3 100644 > --- a/hw/core/irq.c > +++ b/hw/core/irq.c > @@ -68,6 +68,17 @@ qemu_irq *qemu_allocate_irqs(qemu_irq_handler handler, void *opaque, int n) > return qemu_extend_irqs(NULL, 0, handler, opaque, n); > } > > +qemu_irq qemu_allocate_irq(qemu_irq_handler handler, void *opaque, int n) > +{ > + struct IRQState *irq; > + > + irq = g_new(struct IRQState, 1); > + irq->handler = handler; > + irq->opaque = opaque; > + irq->n = n; > + > + return irq; > +} > > void qemu_free_irqs(qemu_irq *s) > { > @@ -75,6 +86,11 @@ void qemu_free_irqs(qemu_irq *s) > g_free(s); > } > > +void qemu_free_irq(qemu_irq irq) > +{ > + g_free(irq); > +} > + > static void qemu_notirq(void *opaque, int line, int level) > { > struct IRQState *irq = opaque; > diff --git a/include/hw/irq.h b/include/hw/irq.h > index 610e6b7..f560dea 100644 > --- a/include/hw/irq.h > +++ b/include/hw/irq.h > @@ -30,6 +30,12 @@ static inline void qemu_irq_pulse(qemu_irq irq) > */ > qemu_irq *qemu_allocate_irqs(qemu_irq_handler handler, void *opaque, int n); > > +/* > + * Allocates a single IRQ. The irq is assigned with a handler, an opaque > + * data and the interrupt number Add period at end of line :) no need to repost for this. > + */ > +qemu_irq qemu_allocate_irq(qemu_irq_handler handler, void *opaque, int n); > + > /* Extends an Array of IRQs. Old IRQs have their handlers and opaque data > * preserved. New IRQs are assigned the argument handler and opaque data. > */ > @@ -37,6 +43,7 @@ qemu_irq *qemu_extend_irqs(qemu_irq *old, int n_old, qemu_irq_handler handler, > void *opaque, int n); > > void qemu_free_irqs(qemu_irq *s); > +void qemu_free_irq(qemu_irq irq); > > /* Returns a new IRQ with opposite polarity. */ > qemu_irq qemu_irq_invert(qemu_irq irq); > -- > 1.8.3.1