From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRjJm-0005XV-1y for qemu-devel@nongnu.org; Thu, 03 Oct 2013 09:51:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRjJf-0002lB-Nu for qemu-devel@nongnu.org; Thu, 03 Oct 2013 09:51:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13112) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRjJf-0002l7-GA for qemu-devel@nongnu.org; Thu, 03 Oct 2013 09:51:43 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r93Dpgj1008123 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 3 Oct 2013 09:51:42 -0400 Date: Thu, 3 Oct 2013 16:54:04 +0300 From: "Michael S. Tsirkin" Message-ID: <20131003135404.GA1267@redhat.com> References: <1380807975-13266-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1380807975-13266-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Thu, Oct 03, 2013 at 03:46:11PM +0200, Paolo Bonzini wrote: > PCI is handling resetting of its devices before the bus is reset, > but this is only necessary because qdev is broken and usually does > pre-order reset. Post-order is a much better definition. Drop > the unnecessary flexibility that lets bus decide the reset order, > convert to post-order, and make PCI use common code for reset. Need to go carefully here. I remember a bunch of targets were relying on reset in this order, though don't have the detail right now. What kind of testing did this patchset go through? > Paolo Bonzini (4): > pci: do not export pci_bus_reset > pci: clean up resetting of IRQs > qdev: allow both pre- and post-order vists in qdev walking functions > qdev: switch reset to post-order > > hw/core/qdev.c | 47 ++++++++++++++++++++++++++++++++++------------- > hw/pci/pci.c | 42 ++++++++++++++++++++---------------------- > hw/pci/pci_bridge.c | 2 +- > include/hw/pci/pci.h | 1 - > include/hw/qdev-core.h | 15 ++++++++++----- > 5 files changed, 65 insertions(+), 42 deletions(-)