From: Igor Mammedov <imammedo@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support
Date: Fri, 4 Oct 2013 15:20:13 +0200 [thread overview]
Message-ID: <20131004152013.0d0a9cd2@nial.usersys.redhat.com> (raw)
In-Reply-To: <1377082892.31946.7.camel@nilsson.home.kraxel.org>
On Wed, 21 Aug 2013 13:01:32 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:
> Hi,
>
> > +#define ICH9_PROC_BASE 0xaf00
> > +#define ICH9_PROC_LEN 32
>
> No, please don't. It makes it impossible to assign the 0xa000 -> 0xafff
> I/O port window to a PCI bridge. Please lets stop occupy random io
> ports above 0x1000 and burn I/O address space that way.
I'm curios why 0x1000 is any better than 0xa000, it still would be random
port occupation. Is there any guideline which ports could be used and which
shouldn't?
Could we safely move PIIX CPU hotplug 0xaf00-0xaf20 range below 0x1000?
>
> I'd suggest to place it at 0x0a00 instead. Also the dsdt should get a
> device with the address in _CRS so the guest knows those ports are used.
>
> cheers,
> Gerd
>
>
>
>
next prev parent reply other threads:[~2013-10-04 13:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 9:04 [Qemu-devel] [PATCH] q35: fix GPE method for cpu hotplug Hu Tao
2013-08-21 9:04 ` [Qemu-devel] [PATCH 1/2] ich9: update sci on gpe write Hu Tao
2013-09-12 15:22 ` Igor Mammedov
2013-09-23 11:20 ` Hu Tao
2013-08-21 9:04 ` [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support Hu Tao
2013-08-21 9:10 ` Hu Tao
2013-08-21 11:01 ` Gerd Hoffmann
2013-08-21 11:27 ` Paolo Bonzini
2013-08-21 11:36 ` Gerd Hoffmann
2013-10-04 13:20 ` Igor Mammedov [this message]
2013-10-07 7:54 ` Gerd Hoffmann
2013-08-21 11:40 ` Andreas Färber
2013-09-12 15:29 ` Igor Mammedov
2013-08-21 11:05 ` [Qemu-devel] [SeaBIOS] [PATCH] q35: fix GPE method for cpu hotplug Gerd Hoffmann
2013-09-10 12:34 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004152013.0d0a9cd2@nial.usersys.redhat.com \
--to=imammedo@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).