From: Gabriel Kerneis <gabriel@kerneis.info>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] config-host.mak: escape configure arguments
Date: Sat, 5 Oct 2013 23:18:21 +0100 [thread overview]
Message-ID: <20131005221820.GA3892@kerneis.info> (raw)
In-Reply-To: <CAFEAcA_jYkiAxQPWOCfVi96Bb8U+i95ni12grxNBKgoP8jAJnw@mail.gmail.com>
On Sun, Oct 06, 2013 at 12:54:08AM +0900, Peter Maydell wrote:
> So this sed script appears to convert literal newlines in the input
> Is that what's intended?
Yes.
> It doesn't seem very useful because if you cut-n-paste (or pipe)
> 'hello\nworld' into a shell you get an actual backslash-n, not a newline.
You're right. Then the best is probably to expect that ./configure parameters
will not get any litteral newline (and remove the sed call doing the
substitution in my patch). Or detect them (with grep) and print an error?
Litteral newlines break badly config-host.mak anyway.
--
Gabriel
next prev parent reply other threads:[~2013-10-05 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 14:41 [Qemu-devel] [PATCH] config-host.mak: escape configure arguments Gabriel Kerneis
2013-10-05 15:54 ` Peter Maydell
2013-10-05 22:18 ` Gabriel Kerneis [this message]
2013-10-06 5:47 ` Stefan Weil
2013-10-06 7:25 ` Gabriel Kerneis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131005221820.GA3892@kerneis.info \
--to=gabriel@kerneis.info \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).