From: Gabriel Kerneis <gabriel@kerneis.info>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] config-host.mak: escape configure arguments
Date: Sun, 6 Oct 2013 08:25:17 +0100 [thread overview]
Message-ID: <20131006072517.GA3931@kerneis.info> (raw)
In-Reply-To: <5250F956.6010009@weilnetz.de>
On Sun, Oct 06, 2013 at 07:47:02AM +0200, Stefan Weil wrote:
> What about removing the comment with the configure parameters
> from config-host.mak?
Sound like a good idea.
> * Easier code - no need to create a configure call from a comment.
Note we still need some escaping for single quotes, but Makefile would be
cleaner indeed.
I can send a new patch implementing this.
--
Gabriel
prev parent reply other threads:[~2013-10-06 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 14:41 [Qemu-devel] [PATCH] config-host.mak: escape configure arguments Gabriel Kerneis
2013-10-05 15:54 ` Peter Maydell
2013-10-05 22:18 ` Gabriel Kerneis
2013-10-06 5:47 ` Stefan Weil
2013-10-06 7:25 ` Gabriel Kerneis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131006072517.GA3931@kerneis.info \
--to=gabriel@kerneis.info \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).