From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTTqD-0007Ad-HU for qemu-devel@nongnu.org; Tue, 08 Oct 2013 05:44:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTTq7-0003k8-Er for qemu-devel@nongnu.org; Tue, 08 Oct 2013 05:44:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTTq7-0003k3-6x for qemu-devel@nongnu.org; Tue, 08 Oct 2013 05:44:27 -0400 Date: Tue, 8 Oct 2013 11:44:28 +0200 From: Kevin Wolf Message-ID: <20131008094428.GC25109@dhcp-200-207.str.redhat.com> References: <1380633619-12213-1-git-send-email-kwolf@redhat.com> <1380633619-12213-15-git-send-email-kwolf@redhat.com> <524B0103.5070306@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <524B0103.5070306@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 14/17] qemu-iotests: Check autodel behaviour for device_del List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: benoit.canet@irqsave.net, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, xiawenc@linux.vnet.ibm.com Am 01.10.2013 um 19:06 hat Eric Blake geschrieben: > On 10/01/2013 07:20 AM, Kevin Wolf wrote: > > Block devices creates with -drive and drive_add should automatically > > disappear if the guest device is unplugged. blockdev-add ones shouldn't. > > > > Signed-off-by: Kevin Wolf > > Reviewed-by: Max Reitz > > --- > > tests/qemu-iotests/064 | 133 +++++++++++++++++++++++++++++++++++++++ > > tests/qemu-iotests/064.out | 80 +++++++++++++++++++++++ > > tests/qemu-iotests/common.filter | 8 +++ > > tests/qemu-iotests/group | 1 + > > 4 files changed, 222 insertions(+) > > create mode 100755 tests/qemu-iotests/064 > > create mode 100644 tests/qemu-iotests/064.out > > Reviewed-by: Eric Blake > > > > + > > +_supported_fmt qcow2 > > +_supported_proto file > > +_supported_os Linux > > Is this test really Linux-only? Probably most tests aren't, but all of them have "_supported_os Linux". If anyone wanted to use this for something, they'd have to make a bigger change than just to this patch. Kevin