qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/3] qapi: introduce BlockJobType enum
Date: Tue, 8 Oct 2013 14:49:19 +0200	[thread overview]
Message-ID: <20131008124919.GH25109@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1381224580-14950-1-git-send-email-famz@redhat.com>

Am 08.10.2013 um 11:29 hat Fam Zheng geschrieben:
> Currently, block job type is hard coded string and could be repeated in
> different places in the code base. Introduce a enum type in QAPI to make it
> better for maintenance and introspection. The old BlockJobType struct is
> renamed to BlockJobDriver and its field "job_type" becomes a BlockJobType enum.
> 
> Nothing is changed to the interface.
> 
> Fam Zheng (3):
>   blockjob: rename BlockJobType to BlockJobDriver
>   qapi: Introduce enum BlockJobType
>   qapi: make use of new BlockJobType

Thanks, applied to the block branch.

Kevin

      parent reply	other threads:[~2013-10-08 12:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08  9:29 [Qemu-devel] [PATCH 0/3] qapi: introduce BlockJobType enum Fam Zheng
2013-10-08  9:29 ` [Qemu-devel] [PATCH 1/3] blockjob: rename BlockJobType to BlockJobDriver Fam Zheng
2013-10-08  9:29 ` [Qemu-devel] [PATCH 2/3] qapi: Introduce enum BlockJobType Fam Zheng
2013-10-08  9:29 ` [Qemu-devel] [PATCH 3/3] qapi: make use of new BlockJobType Fam Zheng
2013-10-08 13:06   ` Eric Blake
2013-10-08 12:49 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131008124919.GH25109@dhcp-200-207.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).