From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTWix-0006Gc-D6 for qemu-devel@nongnu.org; Tue, 08 Oct 2013 08:49:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTWir-0005cH-E3 for qemu-devel@nongnu.org; Tue, 08 Oct 2013 08:49:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTWir-0005c6-67 for qemu-devel@nongnu.org; Tue, 08 Oct 2013 08:49:09 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r98Cn8Dx012187 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 8 Oct 2013 08:49:08 -0400 Date: Tue, 8 Oct 2013 14:49:19 +0200 From: Kevin Wolf Message-ID: <20131008124919.GH25109@dhcp-200-207.str.redhat.com> References: <1381224580-14950-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381224580-14950-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/3] qapi: introduce BlockJobType enum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, stefanha@redhat.com Am 08.10.2013 um 11:29 hat Fam Zheng geschrieben: > Currently, block job type is hard coded string and could be repeated in > different places in the code base. Introduce a enum type in QAPI to make it > better for maintenance and introspection. The old BlockJobType struct is > renamed to BlockJobDriver and its field "job_type" becomes a BlockJobType enum. > > Nothing is changed to the interface. > > Fam Zheng (3): > blockjob: rename BlockJobType to BlockJobDriver > qapi: Introduce enum BlockJobType > qapi: make use of new BlockJobType Thanks, applied to the block branch. Kevin