From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTXnq-0004eQ-F8 for qemu-devel@nongnu.org; Tue, 08 Oct 2013 09:58:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTXnk-00049b-Gv for qemu-devel@nongnu.org; Tue, 08 Oct 2013 09:58:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTXnk-00048u-8x for qemu-devel@nongnu.org; Tue, 08 Oct 2013 09:58:16 -0400 Date: Tue, 8 Oct 2013 15:58:24 +0200 From: Kevin Wolf Message-ID: <20131008135824.GJ25109@dhcp-200-207.str.redhat.com> References: <1381226311-23489-1-git-send-email-stefanha@redhat.com> <20131008122550.GD25109@dhcp-200-207.str.redhat.com> <525403C1.2060206@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <525403C1.2060206@redhat.com> Subject: Re: [Qemu-devel] [PATCH] osdep: initialize glib threads in all QEMU tools List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: mario.dechenno@unina2.it, qemu-devel@nongnu.org, Stefan Hajnoczi Am 08.10.2013 um 15:08 hat Paolo Bonzini geschrieben: > Il 08/10/2013 14:25, Kevin Wolf ha scritto: > > The glib documentation says: > > > > Since version 2.24, calling g_thread_init() multiple times is > > allowed, but nothing happens except for the first call. > > > > I take that this means previously it wasn't allowed. qemu's configure > > checks for a minimum version of 2.12, so we seems to support glib > > versions that don't allow g_thread_init() to be called multiple times. > > > > Do we need to protect against this? > > I think that's the point of the "if (!g_thread_supported ())" tests. Ah yes, I think you're right. Not the best function name I've ever seen that glib uses there, but okay. Kevin