From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTeF3-0003Gn-Qe for qemu-devel@nongnu.org; Tue, 08 Oct 2013 16:51:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTeEt-0005dh-8a for qemu-devel@nongnu.org; Tue, 08 Oct 2013 16:50:53 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:46340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTeEs-0005db-Q0 for qemu-devel@nongnu.org; Tue, 08 Oct 2013 16:50:43 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 8 Oct 2013 14:50:42 -0600 Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 18326C90050 for ; Tue, 8 Oct 2013 16:50:39 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp23033.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r98Kod5B786812 for ; Tue, 8 Oct 2013 20:50:39 GMT Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r98KodNe002164 for ; Tue, 8 Oct 2013 16:50:39 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1381213399-11487-1-git-send-email-wudxw@linux.vnet.ibm.com> References: <1381213399-11487-1-git-send-email-wudxw@linux.vnet.ibm.com> Message-ID: <20131008205038.28259.5217@loki> Date: Tue, 08 Oct 2013 15:50:38 -0500 Subject: Re: [Qemu-devel] [PATCH v4] Extend qemu-ga's 'guest-info' command to expose flag 'success-response' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Wu , Qemu-devel@nongnu.org Cc: Luiz Capitulino Quoting Mark Wu (2013-10-08 01:23:19) > Now we have several qemu-ga commands not returning response on success. > It has been documented in qga/qapi-schema.json already. This patch exposes > the 'success-response' flag by extending 'guest-info' command. With this > change, the clients can handle the command response more flexibly. > = > Signed-off-by: Mark Wu Reviewed-by: Michael Roth Will apply on top of 'Add interface to traverse ...' patch once that goes in. > --- > Changes: > v4: = > Add signature of qmp_has_success_response per Michael. > v3: = > 1. treat cmd->options as a bitmask instead of single option (per = Eric) = > 2. rebase on the patch " Add interface to traverse the qmp comman= d list > by QmpCommand" to avoid the O(n2) problem (per Eric and Michael) > v2: = > add the notation 'since 1.7' to the option 'success-response' > (per Eric Blake's comments) > = > include/qapi/qmp/dispatch.h | 1 + > qapi/qmp-registry.c | 5 +++++ > qga/commands.c | 1 + > qga/qapi-schema.json | 5 ++++- > 4 files changed, 11 insertions(+), 1 deletion(-) > = > diff --git a/include/qapi/qmp/dispatch.h b/include/qapi/qmp/dispatch.h > index b6eb49e..cebf6aa 100644 > --- a/include/qapi/qmp/dispatch.h > +++ b/include/qapi/qmp/dispatch.h > @@ -48,6 +48,7 @@ QObject *qmp_dispatch(QObject *request); > void qmp_disable_command(const char *name); > void qmp_enable_command(const char *name); > bool qmp_command_is_enabled(const QmpCommand *cmd); > +bool qmp_has_success_response(const QmpCommand *cmd); > QObject *qmp_build_error_object(Error *errp); > typedef void (*qmp_cmd_callback_fn)(QmpCommand *cmd, void *opaque); > void qmp_for_each_command(qmp_cmd_callback_fn fn, void *opaque); > diff --git a/qapi/qmp-registry.c b/qapi/qmp-registry.c > index 3fcf10e..c75c2e8 100644 > --- a/qapi/qmp-registry.c > +++ b/qapi/qmp-registry.c > @@ -71,6 +71,11 @@ bool qmp_command_is_enabled(const QmpCommand *cmd) > return cmd->enabled; > } > = > +bool qmp_has_success_response(const QmpCommand *cmd) > +{ > + return !(cmd->options & QCO_NO_SUCCESS_RESP); > +} > + > void qmp_for_each_command(qmp_cmd_callback_fn fn, void *opaque) > { > QmpCommand *cmd; > diff --git a/qga/commands.c b/qga/commands.c > index 063b22b..7f089ba 100644 > --- a/qga/commands.c > +++ b/qga/commands.c > @@ -54,6 +54,7 @@ static void qmp_command_info(QmpCommand *cmd, void *opa= que) > cmd_info =3D g_malloc0(sizeof(GuestAgentCommandInfo)); > cmd_info->name =3D g_strdup(cmd->name); > cmd_info->enabled =3D qmp_command_is_enabled(cmd); > + cmd_info->success_response =3D qmp_has_success_response(cmd); > = > cmd_info_list =3D g_malloc0(sizeof(GuestAgentCommandInfoList)); > cmd_info_list->value =3D cmd_info; > diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json > index 7155b7a..245f968 100644 > --- a/qga/qapi-schema.json > +++ b/qga/qapi-schema.json > @@ -141,10 +141,13 @@ > # > # @enabled: whether command is currently enabled by guest admin > # > +# @success-response: whether command returns a response on success > +# (since 1.7) > +# > # Since 1.1.0 > ## > { 'type': 'GuestAgentCommandInfo', > - 'data': { 'name': 'str', 'enabled': 'bool' } } > + 'data': { 'name': 'str', 'enabled': 'bool', 'success-response': 'bool'= } } > = > ## > # @GuestAgentInfo > -- = > 1.8.3.1