From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually
Date: Tue, 8 Oct 2013 18:51:55 -0300 [thread overview]
Message-ID: <20131008215155.GA16625@amt.cnet> (raw)
In-Reply-To: <5253BC64.2060105@redhat.com>
On Tue, Oct 08, 2013 at 10:03:48AM +0200, Paolo Bonzini wrote:
> Il 08/10/2013 02:41, Marcelo Tosatti ha scritto:
> > + /* unblock SIGBUS */
> > + pthread_sigmask(SIG_BLOCK, NULL, &oldset);
> > + sigemptyset(&set);
> > + sigaddset(&set, SIGBUS);
> > + pthread_sigmask(SIG_UNBLOCK, &set, NULL);
>
> Please instead modify qemu-thread-posix.c to unblock all per-thread
> signals (SIGBUS, SIGSEGV, SIGILL, SIGFPE and SIGSYS). There is no need
> to keep those blocked.
>
> Paolo
main-loop.c handles SIGBUS via signalfd to emulate MCEs (associated
commits). Therefore it must be blocked.
Note that what this patch does it to maintain the signal handling state
(it saves the previous state, modifies state, restores previous state) so
that its unchanged.
next prev parent reply other threads:[~2013-10-08 21:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 0:41 [Qemu-devel] [patch 0/2] force -mem-path RAM allocation Marcelo Tosatti
2013-10-08 0:41 ` [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually Marcelo Tosatti
2013-10-08 8:03 ` Paolo Bonzini
2013-10-08 21:51 ` Marcelo Tosatti [this message]
2013-10-09 8:05 ` Paolo Bonzini
2013-10-09 19:41 ` Marcelo Tosatti
2013-10-09 21:26 ` Paolo Bonzini
2013-10-10 2:11 ` Marcelo Tosatti
2013-10-10 6:30 ` Paolo Bonzini
2013-10-28 13:48 ` Paolo Bonzini
2013-10-28 19:21 ` [Qemu-devel] qemu: mempath: prefault pages manually (v3) Marcelo Tosatti
2013-10-28 20:51 ` [Qemu-devel] qemu: mempath: prefault pages manually (v4) Marcelo Tosatti
2013-10-28 16:15 ` [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually Peter Maydell
2013-10-08 0:41 ` [Qemu-devel] [patch 2/2] qemu: add -mem-path-force option to force RAM allocation via -mem-path Marcelo Tosatti
2013-10-08 7:32 ` [Qemu-devel] [patch 0/2] force -mem-path RAM allocation Markus Armbruster
2013-10-08 8:02 ` Paolo Bonzini
2013-10-08 22:03 ` Marcelo Tosatti
2013-10-09 6:23 ` Markus Armbruster
2013-10-09 20:05 ` Marcelo Tosatti
2013-10-09 21:27 ` Paolo Bonzini
2013-10-10 15:17 ` Marcelo Tosatti
2013-10-09 7:43 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008215155.GA16625@amt.cnet \
--to=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).