From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51354)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VTo66-0004CJ-Qj
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 03:22:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VTo60-0001E1-PI
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 03:22:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12400)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VTo60-0001Dw-GJ
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 03:22:12 -0400
Date: Wed, 9 Oct 2013 10:24:33 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131009072433.GB30623@redhat.com>
References: <20130928195635.GC1051@redhat.com>
	<CAJnKYQmMDmkOM=c7rGxaqNBNSLtF46P+9DWV7bAoiUKXz84CqA@mail.gmail.com>
	<20130929041547.GA28242@redhat.com>
	<CAJnKYQn1s2WN3AfOr1Uv35Wf_ip6-e5_LUVwWOK-Lz1J4PN4yw@mail.gmail.com>
	<20130930090631.GC20291@redhat.com> <52493F28.5090303@redhat.com>
	<20130930093000.GE20291@redhat.com> <52499D33.9020603@redhat.com>
	<20130930155844.GB10306@redhat.com>
	<CAJnKYQnwJUZ0WAo5EWVuLi=Arw3JN9itKYPQ4473szmUgAD8NQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJnKYQnwJUZ0WAo5EWVuLi=Arw3JN9itKYPQ4473szmUgAD8NQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: liu ping fan <qemulist@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <anthony@codemonkey.ws>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On Wed, Oct 09, 2013 at 11:27:24AM +0800, liu ping fan wrote:
> On Mon, Sep 30, 2013 at 11:58 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Mon, Sep 30, 2013 at 05:48:03PM +0200, Paolo Bonzini wrote:
> >> Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto:
> >> > I was really only talking about q35 here.
> >> > I thought it's ugly that users can control intcap
> >> > directly. Can object_set_property be used after
> >> > qdev_try_create?
> >>
> >> Yes, after that and before qdev_init.  This is how Ping Fan is doing
> >> PIIX right now.
> >>
> >> > PIIX has another issue:
> >> > the default value in hpet is really Q35 specific,
> >> > that's also kind of ugly, isn't it?
> >>
> >> Yeah, perhaps it is.  So are you suggesting the default to be 4 (GSI2 only)?
> >>
> >> Paolo
> >
> > I suggest it fails unless caller set the property.
> >
> Sorry, out of office for a long time, and did not keep up with this
> thread in time.
> When letting the caller set the intcap, we should consider the
> compatibility of q35. For pc-q35-1.7 or later, the caller should set
> the property, otherwise not.

Set it always - just set it to a compatible value for 1.6.

> But how can the caller tell that it runs
> on q35-1.7?
> The essential problem is that "set the property" will always overwrite
> the property which is set up by compatible mechanism. So it is hard to
> implement without breaking the current mechanism. Do you think so?
> 
> Thanks and regards,
> Ping fan

Not that hard.  Fail init if it wasn't set.