Re: [Qemu-devel] [PATCH] osdep: initialize glib threads in all QEMU tools

[Stefan Hajnoczi <stefanha@redhat.com>]

On Tue, Oct 08, 2013 at 03:58:24PM +0200, Kevin Wolf wrote:
> Am 08.10.2013 um 15:08 hat Paolo Bonzini geschrieben:
> > Il 08/10/2013 14:25, Kevin Wolf ha scritto:
> > > The glib documentation says:
> > > 
> > >     Since version 2.24, calling g_thread_init() multiple times is
> > >     allowed, but nothing happens except for the first call.
> > > 
> > > I take that this means previously it wasn't allowed. qemu's configure
> > > checks for a minimum version of 2.12, so we seems to support glib
> > > versions that don't allow g_thread_init() to be called multiple times.
> > > 
> > > Do we need to protect against this?
> > 
> > I think that's the point of the "if (!g_thread_supported ())" tests.
> 
> Ah yes, I think you're right. Not the best function name I've ever seen
> that glib uses there, but okay.

That's correct, g_thread_support() is there to initialize once only.

Stefan