From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51239)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VTqSm-00006f-N7
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 05:53:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VTqSg-00058B-O3
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 05:53:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51443)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VTqSg-000584-Fe
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 05:53:46 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r999rj1m007129
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 9 Oct 2013 05:53:45 -0400
Date: Wed, 9 Oct 2013 11:53:58 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131009095358.GH8994@dhcp-200-207.str.redhat.com>
References: <1381308666-24268-1-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1381308666-24268-1-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] qcow2: Small error path fixes for
	snapshot writing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 09.10.2013 um 10:51 hat Max Reitz geschrieben:
> Errors in qcow2_write_snapshots should always go down the error path. If
> this path is taken, the newly allocated snapshot table clusters are
> abandoned and should thus be freed.
> 
> Furthermore, we should safeguard against a possible future increase of
> QEMU's maximum snapshot name/ID length.

Thanks, applied all to the block branch.

Kevin