From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Liu Ping Fan <qemulist@gmail.com>,
Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet
Date: Thu, 10 Oct 2013 14:41:16 +0300 [thread overview]
Message-ID: <20131010114116.GF7582@redhat.com> (raw)
In-Reply-To: <52567782.1080706@redhat.com>
On Thu, Oct 10, 2013 at 11:46:42AM +0200, Paolo Bonzini wrote:
> Il 10/10/2013 11:41, Michael S. Tsirkin ha scritto:
> >> > Are you sure? This is not done for any other compat property.
> >> >
> >> > Paolo
> > It's done if we use the property from C.
> > See PCI_HOST_PROP_PCI_HOLE64_SIZE.
> >
> > You want compiler to catch errors, that's
> > much better than a runtime failure.
>
> I agree, but I think there should be no need to use the property from C.
>
> Paolo
Well this patchset does use it from C.
If it's done it needs a macro.
next prev parent reply other threads:[~2013-10-10 11:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 7:56 [Qemu-devel] [PATCH v6 0/5] bugs fix for hpet Liu Ping Fan
2013-10-10 7:56 ` [Qemu-devel] [PATCH v6 1/5] hpet: inverse polarity when pin above ISA_NUM_IRQS Liu Ping Fan
2013-10-10 7:56 ` [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet Liu Ping Fan
2013-10-10 9:11 ` Paolo Bonzini
2013-10-11 2:59 ` liu ping fan
2013-10-10 9:16 ` Michael S. Tsirkin
2013-10-10 9:33 ` Paolo Bonzini
2013-10-10 9:41 ` Michael S. Tsirkin
2013-10-10 9:46 ` Paolo Bonzini
2013-10-10 11:41 ` Michael S. Tsirkin [this message]
2013-10-11 2:59 ` liu ping fan
2013-10-11 8:38 ` Paolo Bonzini
2013-10-11 9:18 ` liu ping fan
2013-10-11 11:28 ` Paolo Bonzini
2013-10-14 14:17 ` Michael S. Tsirkin
2013-10-14 14:18 ` Michael S. Tsirkin
2013-10-15 5:24 ` liu ping fan
2013-10-10 7:56 ` [Qemu-devel] [PATCH v6 3/5] PC: use qdev_xx to create hpet instead of sysbus_create_xx Liu Ping Fan
2013-10-10 9:10 ` Paolo Bonzini
2013-10-10 9:24 ` Michael S. Tsirkin
2013-10-10 7:56 ` [Qemu-devel] [PATCH v6 4/5] PC: add hpet compat to trace compatability version Liu Ping Fan
2013-10-10 9:09 ` Paolo Bonzini
2013-10-10 7:56 ` [Qemu-devel] [PATCH v6 5/5] PC: differentiate hpet's interrupt capability on piix and q35 Liu Ping Fan
2013-10-10 9:23 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010114116.GF7582@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).