From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46328)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VUEa2-0004t9-Tp
	for qemu-devel@nongnu.org; Thu, 10 Oct 2013 07:39:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VUEZw-00086v-Qr
	for qemu-devel@nongnu.org; Thu, 10 Oct 2013 07:38:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10666)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VUEZw-00086m-ID
	for qemu-devel@nongnu.org; Thu, 10 Oct 2013 07:38:52 -0400
Date: Thu, 10 Oct 2013 14:41:16 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131010114116.GF7582@redhat.com>
References: <1381391779-27718-1-git-send-email-pingfank@linux.vnet.ibm.com>
	<1381391779-27718-3-git-send-email-pingfank@linux.vnet.ibm.com>
	<20131010091614.GA7089@redhat.com> <52567453.50204@redhat.com>
	<20131010094109.GA7295@redhat.com> <52567782.1080706@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52567782.1080706@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq
	pins for hpet
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Liu Ping Fan <qemulist@gmail.com>, Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org

On Thu, Oct 10, 2013 at 11:46:42AM +0200, Paolo Bonzini wrote:
> Il 10/10/2013 11:41, Michael S. Tsirkin ha scritto:
> >> > Are you sure?  This is not done for any other compat property.
> >> > 
> >> > Paolo
> > It's done if we use the property from C.
> > See PCI_HOST_PROP_PCI_HOLE64_SIZE.
> > 
> > You want compiler to catch errors, that's
> > much better than a runtime failure.
> 
> I agree, but I think there should be no need to use the property from C.
> 
> Paolo

Well this patchset does use it from C.
If it's done it needs a macro.