From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUXHV-00033L-7b for qemu-devel@nongnu.org; Fri, 11 Oct 2013 03:37:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUXHP-0004bM-5J for qemu-devel@nongnu.org; Fri, 11 Oct 2013 03:37:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUXHO-0004bI-U2 for qemu-devel@nongnu.org; Fri, 11 Oct 2013 03:36:59 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9B7awgM029869 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 11 Oct 2013 03:36:58 -0400 Date: Fri, 11 Oct 2013 15:36:55 +0800 From: Fam Zheng Message-ID: <20131011073655.GA29253@T430s.nay.redhat.com> References: <1381408712-21502-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381408712-21502-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/2] vmdk: convert error reporting Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com On Thu, 10/10 20:38, Fam Zheng wrote: > The first patch converts "fprintf(stderr,..." to error_setg with errp, and > fixes style of error message texts. > > The second patch checks the compatibility of zeroed_grain flag and flat type > and reports error if both are true. > > v2: [01] More conversion of error messages, also catch error from > bdrv_{pread,pwrite} with error_setg_errno. > 059 fails because of error message format change. (I missed this specific case in the patch publish script). Will send another version to include the test case output updates. Fam