qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 0/2] vmdk: convert error reporting
Date: Fri, 11 Oct 2013 12:03:29 +0200	[thread overview]
Message-ID: <20131011100329.GF3112@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1381477403-25759-1-git-send-email-famz@redhat.com>

Am 11.10.2013 um 09:43 hat Fam Zheng geschrieben:
> The first patch converts "fprintf(stderr,..." to error_setg with errp, and
> fixes style of error message texts.
> 
> The second patch checks the compatibility of zeroed_grain flag and flat type
> and reports error if both are true.
> 
> v3: Update qemu-iotests.
> 
> v2: [01] More conversion of error messages, also catch error from
>          bdrv_{pread,pwrite} with error_setg_errno.
> 
> Fam Zheng (2):
>   vmdk: convert error code to use errp
>   vmdk: refuse enabling zeroed grain with flat images

Thanks, applied both to the block branch.

There are still (q)error_report calls in vmdk_open_vmdk4(), as well as
an error return without a message. The latter also happens in
vmdk_open_sparse(), vmdk_open_desc_file() vmdk_open() and vmdk_create().

This can be addressed in a follow-up series.

Kevin

      parent reply	other threads:[~2013-10-11 10:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11  7:43 [Qemu-devel] [PATCH v3 0/2] vmdk: convert error reporting Fam Zheng
2013-10-11  7:43 ` [Qemu-devel] [PATCH v3 1/2] vmdk: convert error code to use errp Fam Zheng
2013-10-11  7:43 ` [Qemu-devel] [PATCH v3 2/2] vmdk: refuse enabling zeroed grain with flat images Fam Zheng
2013-10-11 10:03 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131011100329.GF3112@dhcp-200-207.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).