From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53156)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VUZZO-0005XO-TB
	for qemu-devel@nongnu.org; Fri, 11 Oct 2013 06:03:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VUZZE-0008Jz-PF
	for qemu-devel@nongnu.org; Fri, 11 Oct 2013 06:03:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61844)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VUZZE-0008Jn-Gv
	for qemu-devel@nongnu.org; Fri, 11 Oct 2013 06:03:32 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9BA3V1I011221
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 11 Oct 2013 06:03:31 -0400
Date: Fri, 11 Oct 2013 12:03:29 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131011100329.GF3112@dhcp-200-207.str.redhat.com>
References: <1381477403-25759-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1381477403-25759-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/2] vmdk: convert error reporting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

Am 11.10.2013 um 09:43 hat Fam Zheng geschrieben:
> The first patch converts "fprintf(stderr,..." to error_setg with errp, and
> fixes style of error message texts.
> 
> The second patch checks the compatibility of zeroed_grain flag and flat type
> and reports error if both are true.
> 
> v3: Update qemu-iotests.
> 
> v2: [01] More conversion of error messages, also catch error from
>          bdrv_{pread,pwrite} with error_setg_errno.
> 
> Fam Zheng (2):
>   vmdk: convert error code to use errp
>   vmdk: refuse enabling zeroed grain with flat images

Thanks, applied both to the block branch.

There are still (q)error_report calls in vmdk_open_vmdk4(), as well as
an error return without a message. The latter also happens in
vmdk_open_sparse(), vmdk_open_desc_file() vmdk_open() and vmdk_create().

This can be addressed in a follow-up series.

Kevin