From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60294)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VViuz-00043b-Gl
	for qemu-devel@nongnu.org; Mon, 14 Oct 2013 10:14:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VVius-0005ul-Ip
	for qemu-devel@nongnu.org; Mon, 14 Oct 2013 10:14:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64749)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VVius-0005uc-A0
	for qemu-devel@nongnu.org; Mon, 14 Oct 2013 10:14:38 -0400
Date: Mon, 14 Oct 2013 17:17:09 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131014141709.GA19575@redhat.com>
References: <1381391779-27718-1-git-send-email-pingfank@linux.vnet.ibm.com>
	<1381391779-27718-3-git-send-email-pingfank@linux.vnet.ibm.com>
	<20131010091614.GA7089@redhat.com> <52567453.50204@redhat.com>
	<20131010094109.GA7295@redhat.com> <52567782.1080706@redhat.com>
	<20131010114116.GF7582@redhat.com>
	<CAJnKYQ=EaWanyMep_jVR6jus8WfOV+PDEaDTTW-d2yPGCdUcXw@mail.gmail.com>
	<5257B8F9.3010703@redhat.com>
	<CAJnKYQm3n98AZe84ViiN6mtDNTEH_uBF-9HjZFiUFpc0Pf_23w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJnKYQm3n98AZe84ViiN6mtDNTEH_uBF-9HjZFiUFpc0Pf_23w@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq
	pins for hpet
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: liu ping fan <qemulist@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>

On Fri, Oct 11, 2013 at 05:18:30PM +0800, liu ping fan wrote:
> On Fri, Oct 11, 2013 at 4:38 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > Il 11/10/2013 04:59, liu ping fan ha scritto:
> >> On Thu, Oct 10, 2013 at 7:41 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> >>> On Thu, Oct 10, 2013 at 11:46:42AM +0200, Paolo Bonzini wrote:
> >>>> Il 10/10/2013 11:41, Michael S. Tsirkin ha scritto:
> >>>>>>> Are you sure?  This is not done for any other compat property.
> >>>>>>>
> >>>>>>> Paolo
> >>>>> It's done if we use the property from C.
> >>>>> See PCI_HOST_PROP_PCI_HOLE64_SIZE.
> >>>>>
> >>>>> You want compiler to catch errors, that's
> >>>>> much better than a runtime failure.
> >>>>
> >>>> I agree, but I think there should be no need to use the property from C.
> >>>>
> >>>> Paolo
> >>>
> >>> Well this patchset does use it from C.
> >>> If it's done it needs a macro.
> >>
> >> hpet.h is the ideal place to put the macro, so pc.c can see it. But
> >> what about PC_COMPAT_1_7 in pc.h? I think it is not right to include
> >> hpet.h. So can I do not use marco in pc.h?
> >
> > I think you shouldn't need the macro (no need to use the property from
> > C, only from compat properties).
> >
> We need to tell the compat and then decide to set "intcap" in
> pc_basic_device_init()
> 
>                 uint8_t compat = object_property_get_int(OBJECT(hpet),
>                         "intcap", NULL);
>                 if (!compat) {
>                     qdev_prop_set_uint32(hpet, "intcap", 0xff0104);
>                 }
> 
> Regards,
> Ping Fan

So if you use it from C, please use a macro.
If not, no need to.