qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete
Date: Tue, 15 Oct 2013 11:12:06 +0800	[thread overview]
Message-ID: <20131015031206.GA12030@T430s.nay.redhat.com> (raw)
In-Reply-To: <525CB0E7.8000707@redhat.com>

On Mon, 10/14 21:05, Eric Blake wrote:
> On 10/14/2013 08:23 PM, Fam Zheng wrote:
> > There is errp passed in, so no need for local_err and error_propagate.
> > Also drop the backing_filename which is set but unused since 34b5d2c.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > 
> > --
> 
> Three dashes instead of two before 'git am' will notice that the rest of
> the comment is mail-only.

Sorry, stingy me.

> 
> > v2: fix typo in subject line.
> >     drop backing_filename.
> >     (Thanks Eric)
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  block/mirror.c | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 

Thanks,
Fam

  reply	other threads:[~2013-10-15  3:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15  2:23 [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete Fam Zheng
2013-10-15  3:05 ` Eric Blake
2013-10-15  3:12   ` Fam Zheng [this message]
2013-10-16 18:56 ` Max Reitz
2013-10-17 12:49   ` Stefan Hajnoczi
2013-10-17 13:00     ` Kevin Wolf
2013-10-18  8:51       ` Fam Zheng
2013-10-18 17:59         ` Max Reitz
2013-10-19  8:05           ` Kevin Wolf
2013-10-19 20:02             ` Max Reitz
2013-10-19  8:50           ` Paolo Bonzini
2013-10-18  8:52       ` Stefan Hajnoczi
2013-10-17 12:51   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131015031206.GA12030@T430s.nay.redhat.com \
    --to=famz@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).