From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50720)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <drjones@redhat.com>) id 1VW07O-0004ye-6F
	for qemu-devel@nongnu.org; Tue, 15 Oct 2013 04:36:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <drjones@redhat.com>) id 1VW07I-00016h-7A
	for qemu-devel@nongnu.org; Tue, 15 Oct 2013 04:36:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20459)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <drjones@redhat.com>) id 1VW07H-00016Z-Vj
	for qemu-devel@nongnu.org; Tue, 15 Oct 2013 04:36:36 -0400
Date: Tue, 15 Oct 2013 10:36:19 +0200
From: Andrew Jones <drjones@redhat.com>
Message-ID: <20131015083618.GA2181@hawk.usersys.redhat.com>
References: <1381766368-7991-1-git-send-email-drjones@redhat.com>
	<CAAhSdy0v5uV11DgSDsKcRDq-jEqK=n6GZGGR+iUzY8Y9RqwJKg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAhSdy0v5uV11DgSDsKcRDq-jEqK=n6GZGGR+iUzY8Y9RqwJKg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] virtio: Introduce virtio-testdev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anup Patel <anup@brainfault.org>
Cc: qemu-devel@nongnu.org, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>

On Tue, Oct 15, 2013 at 12:26:10PM +0530, Anup Patel wrote:
> Hi Andrew,
> 
> On Mon, Oct 14, 2013 at 9:29 PM, Andrew Jones <drjones@redhat.com> wrote:
> > This is a virtio version of hw/misc/debugexit and should evolve into a
> > virtio version of pc-testdev. pc-testdev uses the PC's ISA bus, whereas
> > this testdev can be plugged into a virtio-mmio transport, which is
> > needed for kvm-unit-tests/arm. virtio-testdev uses the virtio device
> > config space as a communication channel, and implements an RTAS-like
> > protocol through it allowing guests to execute commands. Only three
> > commands are currently implemented;
> > 1) VERSION: for version compatibility checks
> > 2) CLEAR:   set all the config space back to zero
> > 3) EXIT:    exit() from qemu with a status code
> 
> How about adding RESET command to reset the VM?
> 

Hi Anup,

I'm not opposed to it, but at the moment I'm not sure how we would
utilize it within kvm-unit-tests. Maybe it would be useful for another
application though? So maybe we can add it as an add-on patch at the
time we come up with its use case?

Thanks for the review!

drew