From: Gleb Natapov <gleb@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anup Patel <anup@brainfault.org>,
QEMU Developers <qemu-devel@nongnu.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: Re: [Qemu-devel] [PATCH] virtio: Introduce virtio-testdev
Date: Tue, 15 Oct 2013 13:38:57 +0300 [thread overview]
Message-ID: <20131015103857.GY15657@redhat.com> (raw)
In-Reply-To: <CAFEAcA9uu+aBRsO-aPMR0Mh_zHBuZcnEZfnGuOexGZ+3Qa4ifQ@mail.gmail.com>
On Tue, Oct 15, 2013 at 11:14:12AM +0100, Peter Maydell wrote:
> On 15 October 2013 10:47, Anup Patel <anup@brainfault.org> wrote:
> > On Tue, Oct 15, 2013 at 2:06 PM, Andrew Jones <drjones@redhat.com> wrote:
> >> I'm not opposed to it, but at the moment I'm not sure how we would
> >> utilize it within kvm-unit-tests. Maybe it would be useful for another
> >> application though? So maybe we can add it as an add-on patch at the
> >> time we come up with its use case?
> >
> > I suggested it because we have "machvirt" machine in QEMU for
> > KVM ARM/ARM64 which has only VirtIO devices. In "machvirt", we
> > don't have mechanism to reset the system because none of the
> > VirtIO devices have such a mechanism. Now since you are introducing
> > a "testdev", we can have a RESET command in VirtIO and implement
> > VirtIO REBOOT driver in Linux kernel to use it.
> >
> > Currently, due to no RESET support in "machvirt" we are not able
> > to reboot Guest Linux from Guest console.
>
> We shouldn't be abusing a device intended for testing to
> provide necessary features. If we need guest reboot support
> (which seems like an obvious thing to want) then we need
> to implement a sensible mechanism for it.
>
Definitely. Test device is only for use by unit tests. It does not normally
present and may contain hacks not suitable for human consumption.
--
Gleb.
next prev parent reply other threads:[~2013-10-15 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 15:59 [Qemu-devel] [PATCH] virtio: Introduce virtio-testdev Andrew Jones
2013-10-15 6:56 ` Anup Patel
2013-10-15 8:36 ` Andrew Jones
2013-10-15 9:47 ` Anup Patel
2013-10-15 9:51 ` Anup Patel
2013-10-15 10:14 ` Peter Maydell
2013-10-15 10:38 ` Gleb Natapov [this message]
2013-10-15 10:50 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015103857.GY15657@redhat.com \
--to=gleb@redhat.com \
--cc=anup@brainfault.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).