From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56043)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VW5Vg-0006KI-ES
	for qemu-devel@nongnu.org; Tue, 15 Oct 2013 10:22:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VW5Va-0006f6-0V
	for qemu-devel@nongnu.org; Tue, 15 Oct 2013 10:22:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54809)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VW5VZ-0006f1-Nb
	for qemu-devel@nongnu.org; Tue, 15 Oct 2013 10:22:01 -0400
Date: Tue, 15 Oct 2013 17:24:29 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131015142429.GC7613@redhat.com>
References: <1381762577-12526-1-git-send-email-mst@redhat.com>
	<87r4bnlbj6.fsf@codemonkey.ws> <20131015052816.GC16331@redhat.com>
	<CA+aC4kvGLGQh0rtjh3Xg5S7yS7MKEH7Y4Gx9vaSG035m2dUVew@mail.gmail.com>
	<525D4AC4.1000408@redhat.com>
	<CA+aC4kuLEy40ePQ1K0W7k4q8SjbP7PEiZ48j6djhatXU43PkWw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+aC4kuLEy40ePQ1K0W7k4q8SjbP7PEiZ48j6djhatXU43PkWw@mail.gmail.com>
Subject: Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>, marcel.a@redhat.com, qemu-devel <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Tue, Oct 15, 2013 at 07:17:59AM -0700, Anthony Liguori wrote:
> On Tue, Oct 15, 2013 at 7:01 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > Il 15/10/2013 15:51, Anthony Liguori ha scritto:
> >> From 41/43:
> >>
> >> "The interface is actually backwards-compatible with
> >>  existing PIIX4 ACPI (though not migration compatible)."
> >>
> >> And does "AFAIK" translate to, "I have tested migration from new and
> >> old and old and new with this series"?  I suspect the answer is no.
> >
> > Since when do we support migration from new to old?
> 
> We allow it to break because we only send the newest version of things
> but we should try our best to avoid that from happening.  That's why
> we have things like subsections.
> 
> Regards,
> 
> Anthony Liguori
> 
> > Paolo

I addressed this using _TEST VMSTATE macros:

+static bool vmstate_test_use_acpi_pci_hotplug(void *opaque, int version_id)
+{
+    PIIX4PMState *s = opaque;
+    return s->use_acpi_pci_hotplug;
+}
+
+static bool vmstate_test_no_use_acpi_pci_hotplug(void *opaque, int version_id)
+{
+    PIIX4PMState *s = opaque;
+    return !s->use_acpi_pci_hotplug;
+}
+


use_acpi_pci_hotplug is set only for new machine.

Did you miss this during review or is something wrong with this?

-- 
MST