From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59990)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VW5gP-0004uh-En
	for qemu-devel@nongnu.org; Tue, 15 Oct 2013 10:33:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VW5gJ-00025L-GV
	for qemu-devel@nongnu.org; Tue, 15 Oct 2013 10:33:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1200)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VW5gJ-00025H-89
	for qemu-devel@nongnu.org; Tue, 15 Oct 2013 10:33:07 -0400
Date: Tue, 15 Oct 2013 17:35:30 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131015143530.GA7763@redhat.com>
References: <1381762577-12526-1-git-send-email-mst@redhat.com>
	<1381762577-12526-43-git-send-email-mst@redhat.com>
	<525D51C3.2050201@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <525D51C3.2050201@redhat.com>
Subject: Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, marcel.a@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com, Anthony Liguori <anthony@codemonkey.ws>, imammedo@redhat.com

On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote:
> Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto:
> > -        VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status,
> > -                       struct pci_status),
> > +        VMSTATE_STRUCT_TEST(pci0_status, PIIX4PMState,
> > +                            vmstate_test_no_use_acpi_pci_hotplug,
> > +                            2, vmstate_pci_status,
> > +                            struct pci_status),
> 
> There's no reason to remove this from the stream when a new machine type
> is in use.  You'll just send out zeroes.

Seemed cleaner not to.

> > +        VMSTATE_PCI_HOTPLUG(acpi_pci_hotplug, PIIX4PMState,
> > +                            vmstate_test_use_acpi_pci_hotplug),
> 
> This works, but it is a bit different from other cases that are already
> present, which use a subsection.  It is a bit ugly because it looks like
> a version-1 field, but in fact it is not version 1.
> 
> I'll let other people decide whether it's acceptable or not, but I'm
> leaning towards asking you to use a subsection.
> 
> Paolo