From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VW6Bh-0006Yc-KS for qemu-devel@nongnu.org; Tue, 15 Oct 2013 11:05:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VW6Bb-0005ik-Kh for qemu-devel@nongnu.org; Tue, 15 Oct 2013 11:05:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VW6Bb-0005ib-DQ for qemu-devel@nongnu.org; Tue, 15 Oct 2013 11:05:27 -0400 Date: Tue, 15 Oct 2013 18:07:54 +0300 From: "Michael S. Tsirkin" Message-ID: <20131015150754.GA8101@redhat.com> References: <1381762577-12526-1-git-send-email-mst@redhat.com> <1381762577-12526-43-git-send-email-mst@redhat.com> <525D51C3.2050201@redhat.com> <20131015143530.GA7763@redhat.com> <525D5630.1030801@redhat.com> <20131015145450.GA7897@redhat.com> <525D5720.2030908@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <525D5720.2030908@redhat.com> Subject: Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, marcel.a@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com, Anthony Liguori , imammedo@redhat.com On Tue, Oct 15, 2013 at 04:54:24PM +0200, Paolo Bonzini wrote: > Il 15/10/2013 16:54, Michael S. Tsirkin ha scritto: > > > > Seemed cleaner not to. > > > > > > It certainly would be if we had a self-descriptive migration stream format. > > > > > > However, what we have is "send bytes, parse them on the destination, > > > hope the format matches". Hence, anything that makes the format less > > > declarative adds to the complication and complicates debugging. This is > > > the same reason why I prefer a subsection for the new hotplug stuff---it > > > makes the format more declarative and self-descriptive. > > > > I understand for the subsection but why is removing > > useless bytes from there making it less descriptive? > > Because the same version can have multiple formats depending on a datum > that is not part of the migration stream. > > Paolo I see. Will it be OK if I'll update the version?