From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VW6h7-0006BT-Or for qemu-devel@nongnu.org; Tue, 15 Oct 2013 11:38:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VW6h1-0000XZ-Pr for qemu-devel@nongnu.org; Tue, 15 Oct 2013 11:38:01 -0400 Date: Tue, 15 Oct 2013 18:40:14 +0300 From: "Michael S. Tsirkin" Message-ID: <20131015154014.GA8760@redhat.com> References: <1381848773-689-1-git-send-email-pbonzini@redhat.com> <1381848773-689-5-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381848773-689-5-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 04/12] virtio-pci: remove vdev field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: cornelia.huck@de.ibm.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org, afaerber@suse.de On Tue, Oct 15, 2013 at 04:52:45PM +0200, Paolo Bonzini wrote: > @@ -257,7 +271,7 @@ static void virtio_pci_stop_ioeventfd(VirtIOPCIProxy *proxy) > static void virtio_ioport_write(void *opaque, uint32_t addr, uint32_t val) > { > VirtIOPCIProxy *proxy = opaque; > - VirtIODevice *vdev = proxy->vdev; > + VirtIODevice *vdev = virtio_bus_get_device(&proxy->bus); > hwaddr pa; > > switch (addr) { Hmm this is also datapath. Can this use direct access too, like MSIX?