From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, afaerber@suse.de, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 01/12] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug
Date: Tue, 15 Oct 2013 17:05:03 +0200 [thread overview]
Message-ID: <20131015170503.64d6d162@gondolin> (raw)
In-Reply-To: <1381848773-689-2-git-send-email-pbonzini@redhat.com>
On Tue, 15 Oct 2013 16:52:42 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Similar to the PCI bug that prompted these patches, virtio-ccw will
> segfault after the reworking of hotplug/hot-unplug. Prepare for
> this by moving virtio_ccw_stop_ioeventfd to before the freeing
> of the proxy device.
>
> A better place for this could be the device_unplugged callback
> for the virtio-ccw bus. However, we do not yet have a callback
> that works: this patch avoids the problem while leaving the tree
> bisectable.
>
> Reported-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Suggested-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/s390x/virtio-ccw.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2013-10-15 15:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 14:52 [Qemu-devel] [PATCH v2 00/12] virtio: cleanup and fix hot-unplug Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 01/12] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug Paolo Bonzini
2013-10-15 15:05 ` Cornelia Huck [this message]
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 02/12] virtio-bus: remove vdev field Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 03/12] virtio-ccw: " Paolo Bonzini
2013-10-15 15:19 ` Cornelia Huck
2013-10-15 15:59 ` Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 04/12] virtio-pci: " Paolo Bonzini
2013-10-15 15:40 ` Michael S. Tsirkin
2013-10-15 15:53 ` Paolo Bonzini
2013-10-15 16:06 ` Michael S. Tsirkin
2013-10-15 16:42 ` Paolo Bonzini
2013-10-15 20:11 ` Michael S. Tsirkin
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 05/12] virtio-bus: cleanup plug/unplug interface Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 06/12] virtio-blk: switch exit callback to VirtioDeviceClass Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 07/12] virtio-serial: " Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 08/12] virtio-net: " Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 09/12] virtio-scsi: " Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 10/12] virtio-balloon: " Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 11/12] virtio-rng: " Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 12/12] virtio-pci: add device_unplugged callback Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015170503.64d6d162@gondolin \
--to=cornelia.huck@de.ibm.com \
--cc=afaerber@suse.de \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).