From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VW6BW-0006Vl-8P for qemu-devel@nongnu.org; Tue, 15 Oct 2013 11:05:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VW6BN-0005d5-6X for qemu-devel@nongnu.org; Tue, 15 Oct 2013 11:05:22 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:46608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VW6BM-0005cN-U0 for qemu-devel@nongnu.org; Tue, 15 Oct 2013 11:05:13 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 15 Oct 2013 16:05:11 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 19C5F17D806B for ; Tue, 15 Oct 2013 16:05:33 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r9FF4uiJ36176018 for ; Tue, 15 Oct 2013 15:04:56 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r9FF58pQ009550 for ; Tue, 15 Oct 2013 09:05:08 -0600 Date: Tue, 15 Oct 2013 17:05:03 +0200 From: Cornelia Huck Message-ID: <20131015170503.64d6d162@gondolin> In-Reply-To: <1381848773-689-2-git-send-email-pbonzini@redhat.com> References: <1381848773-689-1-git-send-email-pbonzini@redhat.com> <1381848773-689-2-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 01/12] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, afaerber@suse.de, mst@redhat.com On Tue, 15 Oct 2013 16:52:42 +0200 Paolo Bonzini wrote: > Similar to the PCI bug that prompted these patches, virtio-ccw will > segfault after the reworking of hotplug/hot-unplug. Prepare for > this by moving virtio_ccw_stop_ioeventfd to before the freeing > of the proxy device. > > A better place for this could be the device_unplugged callback > for the virtio-ccw bus. However, we do not yet have a callback > that works: this patch avoids the problem while leaving the tree > bisectable. > > Reported-by: Cornelia Huck > Suggested-by: Cornelia Huck > Signed-off-by: Paolo Bonzini > --- > hw/s390x/virtio-ccw.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Cornelia Huck