From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWV0m-0003ys-55 for qemu-devel@nongnu.org; Wed, 16 Oct 2013 13:35:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWV0i-0002M8-A8 for qemu-devel@nongnu.org; Wed, 16 Oct 2013 13:35:56 -0400 Date: Wed, 16 Oct 2013 18:21:09 +0100 From: "Daniel P. Berrange" Message-ID: <20131016172109.GX23150@redhat.com> References: <1381943828-7948-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1381943828-7948-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1.7] monitor: eliminate monitor_event_state_lock Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org On Wed, Oct 16, 2013 at 07:17:08PM +0200, Paolo Bonzini wrote: > This lock does not protect anything that the BQL does not already > protect. Furthermore, with -nodefaults and no monitor, the mutex > is not initialized but monitor_protocol_event_queue is called > anyway, which causes a crash under mingw (and only works by luck. > under Linux or other POSIX OSes). > > Reported-by: Orx Goshen > Cc: Daniel Berrange > Cc: qemu-stable@nongnu.org > Signed-off-by: Paolo Bonzini > --- > Maybe I'm missing something? ACK, I only added it because I wasn't clear on wether the BQL was sufficient, so it was just a safety net. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|