From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWX18-0008U4-9k for qemu-devel@nongnu.org; Wed, 16 Oct 2013 15:44:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWX12-0001yq-AN for qemu-devel@nongnu.org; Wed, 16 Oct 2013 15:44:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWX12-0001xp-2V for qemu-devel@nongnu.org; Wed, 16 Oct 2013 15:44:20 -0400 Date: Wed, 16 Oct 2013 22:46:53 +0300 From: "Michael S. Tsirkin" Message-ID: <20131016194653.GA10517@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kvm@vger.kernel.org Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, gleb@redhat.com Old GCC didn't let you reference variable by number if it is listed with a specific register constraint, on the assumption you can just use the register name explicitly. Build fails with errors like this: a.c:6: error: invalid 'asm': invalid operand code 'd' To fix, let's just use %eax %al etc. Signed-off-by: Michael S. Tsirkin --- lib/x86/pci.c | 4 ++-- x86/s3.c | 4 ++-- x86/vmexit.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/x86/pci.c b/lib/x86/pci.c index f95cd88..08f7ebf 100644 --- a/lib/x86/pci.c +++ b/lib/x86/pci.c @@ -3,13 +3,13 @@ static void outl(unsigned short port, unsigned val) { - asm volatile("outl %d0, %w1" : : "a"(val), "Nd"(port)); + asm volatile("outl %%eax, %w1" : : "a"(val), "Nd"(port)); } static unsigned inl(unsigned short port) { unsigned data; - asm volatile("inl %w1, %d0" : "=a"(data) : "Nd"(port)); + asm volatile("inl %w1, %%eax" : "=a"(data) : "Nd"(port)); return data; } static uint32_t pci_config_read(pcidevaddr_t dev, uint8_t reg) diff --git a/x86/s3.c b/x86/s3.c index 1feb452..eeffa17 100644 --- a/x86/s3.c +++ b/x86/s3.c @@ -149,8 +149,8 @@ static inline int rtc_in(u8 reg) static inline void rtc_out(u8 reg, u8 val) { - asm volatile("outb %b1, $0x70; mov %b2, %b1; outb %b1, $0x71" - : "+a"(reg) : "0"(reg), "ri"(val)); + asm volatile("outb %%al, $0x70; mov %b1, %%al; outb %%al, $0x71" + : "+a"(reg) : "ri"(val)); } extern char resume_start, resume_end; diff --git a/x86/vmexit.c b/x86/vmexit.c index 3b945de..29bc582 100644 --- a/x86/vmexit.c +++ b/x86/vmexit.c @@ -26,7 +26,7 @@ static void outw(unsigned short port, unsigned val) static void outl(unsigned short port, unsigned val) { - asm volatile("outl %d0, %w1" : : "a"(val), "Nd"(port)); + asm volatile("outl %%eax, %w1" : : "a"(val), "Nd"(port)); } static unsigned int inb(unsigned short port) -- MST