From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWgC1-0000Na-96 for qemu-devel@nongnu.org; Thu, 17 Oct 2013 01:32:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWgBv-0002A1-A6 for qemu-devel@nongnu.org; Thu, 17 Oct 2013 01:32:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWgBv-00029w-1t for qemu-devel@nongnu.org; Thu, 17 Oct 2013 01:32:11 -0400 Date: Thu, 17 Oct 2013 08:34:42 +0300 From: "Michael S. Tsirkin" Message-ID: <20131017053442.GD12141@redhat.com> References: <525D5630.1030801@redhat.com> <87txgimrd6.fsf@codemonkey.ws> <20131015201706.GB9579@redhat.com> <20131016181800.GB7100@redhat.com> <20131016183732.GA8157@redhat.com> <525F0473.6060408@redhat.com> <20131016220301.GA10908@redhat.com> <525F125C.80403@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <525F125C.80403@redhat.com> Subject: Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , gleb@redhat.com, marcel.a@redhat.com, qemu-devel , Gerd Hoffmann , Anthony Liguori , Igor Mammedov On Thu, Oct 17, 2013 at 12:25:32AM +0200, Paolo Bonzini wrote: > >> qtest could at best host some sanity checks on the ACPI tables, which > >> would catch the MCFG problems that Gerd reported on v5. > > > > Depends on how deep the test understands ACPI - the signature > > was wrong I think. > > > > Note I was testing this too - comparing tables between > > revisions. I just didn't notice that list of tables > > to test included was generated by me on piix, so > > MCFG wasn't tested. > > So we could have a qtest for sanity checking ACPI tables. At least > fw_cfg is one of the few components that has qtest infrastructure... I > don't think we need to do more than that though. The set of sanity > checks can start with a simple list of tables that "have to be there" > for a given machine type. > > Paolo Well this means these tests won't pass on old qemu so they would be useless for comparing old to new. And in this case, while it's a good idea to have them I don't see why it's a blocker for merging. -- MST