From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47410)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VWgM7-0005P6-VA
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 01:42:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VWgM2-0005Fd-00
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 01:42:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39681)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VWgM1-0005FY-P7
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 01:42:37 -0400
Date: Thu, 17 Oct 2013 08:45:10 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131017054510.GF12141@redhat.com>
References: <1381979765-23092-1-git-send-email-pingfank@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1381979765-23092-1-git-send-email-pingfank@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v7 0/4] bugs fix for hpet
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu Ping Fan <qemulist@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>

On Thu, Oct 17, 2013 at 11:16:01AM +0800, Liu Ping Fan wrote:
> v7:
>   use macro to define "intcap" in pc.h
>   (as to 3/4 and 4/4, I am not sure about whether to merge them or not, so keep them separate")
> 

Yes, please smash 2 3 and 4 together.
There's no need to waste time reviewing code that gets
deleted in the next patch.

> v6:
>   move the setting of intcap to board, and keep the init value as zero. (thanks for the discussion from Paolo and Michael)
>   introduce an extra hpet property "compat" to tell PC version
> 
> v5:
>   use stand compat property to fix hpet intcap on pc-q35, while on pc-piix, hard code intcap as IRQ2
> 
> v4:
>   use stand compat property to fix hpet intcap
> 
> v3:
>   change hpet interrupt capablity on board's demand
> 
> 
> 
> Liu Ping Fan (4):
>   hpet: inverse polarity when pin above ISA_NUM_IRQS
>   hpet: enable to entitle more irq pins for hpet
>   PC: use qdev_xx to create hpet instead of sysbus_create_xx
>   PC: differentiate hpet's interrupt capability on piix and q35
> 
>  hw/i386/pc.c         | 23 ++++++++++++++++++++---
>  hw/i386/pc_piix.c    |  7 ++++++-
>  hw/i386/pc_q35.c     |  6 +++++-
>  hw/timer/hpet.c      | 24 ++++++++++++++++++++----
>  include/hw/i386/pc.h | 13 ++++++++++++-
>  5 files changed, 63 insertions(+), 10 deletions(-)
> 
> -- 
> 1.8.1.4