From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47313)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VWig9-0002kO-Ce
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:11:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VWig3-0007nZ-Eh
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:11:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39431)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VWig3-0007nQ-6i
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:11:27 -0400
Date: Thu, 17 Oct 2013 10:11:14 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131017081114.GB2942@dhcp-200-207.str.redhat.com>
References: <1381979761-2180-1-git-send-email-qiudayu@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1381979761-2180-1-git-send-email-qiudayu@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Cc: benoit@irqsave.net, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com, xiawenc@linux.vnet.ibm.com

Am 17.10.2013 um 05:16 hat Mike Qiu geschrieben:
> Change to v1:
> 	remove '[not inserted]' line instead of adding '\n'

Please put such notes for reviewers below the --- line, so that git am
automatically removes them and they don't end up in the git commit
message.

> Output of 'info block'
> 
> scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2)
>  [not inserted]
> scsi0-cd2: [not inserted]
>     Removable device: not locked, tray closed
> 
> floppy0: [not inserted]
>     Removable device: not locked, tray closed
> 
> sd0: [not inserted]
>     Removable device: not locked, tray closed
> 
> There will be no additional lines between scsi0-hd0 and
> scsi0-cd2.
> 
> At the same time, scsi0-hd0 already inserted, but still has
> '[not inserted]' flag. This line should be removed.
> 
> This patch is to solve this.
> 
> Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>