From: Stefan Hajnoczi <stefanha@gmail.com>
To: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, benoit@irqsave.net, qemu-devel@nongnu.org,
armbru@redhat.com, lcapitulino@redhat.com, stefanha@redhat.com,
xiawenc@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()
Date: Thu, 17 Oct 2013 10:14:01 +0200 [thread overview]
Message-ID: <20131017081401.GB10774@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1381979761-2180-1-git-send-email-qiudayu@linux.vnet.ibm.com>
On Wed, Oct 16, 2013 at 11:16:01PM -0400, Mike Qiu wrote:
> Change to v1:
> remove '[not inserted]' line instead of adding '\n'
>
> Output of 'info block'
>
> scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2)
> [not inserted]
> scsi0-cd2: [not inserted]
> Removable device: not locked, tray closed
>
> floppy0: [not inserted]
> Removable device: not locked, tray closed
>
> sd0: [not inserted]
> Removable device: not locked, tray closed
>
> There will be no additional lines between scsi0-hd0 and
> scsi0-cd2.
>
> At the same time, scsi0-hd0 already inserted, but still has
> '[not inserted]' flag. This line should be removed.
>
> This patch is to solve this.
>
> Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
> ---
> hmp.c | 2 --
> 1 file changed, 2 deletions(-)
The commit message is out-of-date, this patch now drops the bogus "[not
inserted]" output. I fixed up the commit message.
In the future, please put the patch changelog after the "---" line so
that git am does not include the changelog in the commit description.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
next prev parent reply other threads:[~2013-10-17 8:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 3:16 [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf() Mike Qiu
2013-10-17 8:11 ` Kevin Wolf
2013-10-17 8:35 ` mike
2013-10-17 8:14 ` Stefan Hajnoczi [this message]
2013-10-17 8:34 ` mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017081401.GB10774@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qiudayu@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).