From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWihT-0003as-PB for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:13:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWihO-0007yo-W1 for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:12:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWihO-0007ye-Nu for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:12:50 -0400 Date: Thu, 17 Oct 2013 11:15:21 +0300 From: "Michael S. Tsirkin" Message-ID: <20131017081521.GC13975@redhat.com> References: <1381993370-26201-1-git-send-email-akong@redhat.com> <20131017075847.GA10774@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131017075847.GA10774@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] fix updating of nic info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Amos Kong , stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws On Thu, Oct 17, 2013 at 09:58:47AM +0200, Stefan Hajnoczi wrote: > On Thu, Oct 17, 2013 at 03:02:48PM +0800, Amos Kong wrote: > > I tried to change macaddr in guest, addr in guest is updated, and guest > > network is fine. But the nic information in monitor isn't update. This > > problem both exists in e1000 and rtl8139. > > > > 1) change macaddr in guest by ifconfig > > guest)# ifconfig eth0 hw ether 12:12:12:34:35:36 > > guest)# ifconfig eth0 > > > > 2) check network information in monitor > > (qemu) info network > > > > Amos Kong (2): > > net/e1000: update network information when macaddr is changed in guest > > net/rtl8139: update network information when macaddr is changed in > > guest > > > > hw/net/e1000.c | 8 ++++++++ > > hw/net/rtl8139.c | 6 +++++- > > 2 files changed, 13 insertions(+), 1 deletion(-) > > Thanks, applied to my net tree: > https://github.com/stefanha/qemu/commits/net > > Stefan Please revert, this is buggy: info is changed on guest mac write but is not reverted on reset. Let's fix it properly, no need to introduce new regressions when fixing old bugs :) -- MST