From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWijz-0005U1-Uf for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:15:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWiju-0000VH-QX for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:15:31 -0400 Received: from mail-bk0-x22e.google.com ([2a00:1450:4008:c01::22e]:40185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWiju-0000VD-J4 for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:15:26 -0400 Received: by mail-bk0-f46.google.com with SMTP id 6so687112bkj.33 for ; Thu, 17 Oct 2013 01:15:25 -0700 (PDT) Date: Thu, 17 Oct 2013 10:15:23 +0200 From: Stefan Hajnoczi Message-ID: <20131017081523.GC10774@stefanha-thinkpad.redhat.com> References: <1381929841-16460-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1381929841-16460-1-git-send-email-afaerber@suse.de> Subject: Re: [Qemu-devel] [PATCH] sd: Avoid access to NULL BlockDriverState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: kwolf@redhat.com, peter.maydell@linaro.org, stefanha@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com On Wed, Oct 16, 2013 at 03:24:01PM +0200, Andreas Färber wrote: > Commit 4f8a066b5fc254eeaabbbde56ba4f5b29cc68fdf (blockdev: Remove IF_* > check for read-only blockdev_init) added a usage of bdrv_is_read_only() > to sd_init(), which is called for versatilepb, versatileab and > xilinx-zynq-a9 machines among others with NULL argument by default, > causing the new qom-test to fail. > > Add a check to prevent this. > > Suggested-by: Kevin Wolf > Signed-off-by: Andreas Färber > --- > hw/sd/sd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan