From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWioX-0007jz-Ql for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:20:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWioS-00021z-65 for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:20:13 -0400 Received: from mail-bk0-x229.google.com ([2a00:1450:4008:c01::229]:46846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWioR-00021P-VV for qemu-devel@nongnu.org; Thu, 17 Oct 2013 04:20:08 -0400 Received: by mail-bk0-f41.google.com with SMTP id na10so703283bkb.0 for ; Thu, 17 Oct 2013 01:20:07 -0700 (PDT) Date: Thu, 17 Oct 2013 10:20:04 +0200 From: Stefan Hajnoczi Message-ID: <20131017082004.GD10774@stefanha-thinkpad.redhat.com> References: <1381830350-7240-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381830350-7240-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] blockdev: fix cdrom read_only flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, edivaldoapereira@yahoo.com.br On Tue, Oct 15, 2013 at 05:45:50PM +0800, Fam Zheng wrote: > Since 0ebd24e0, cdrom doesn't have read-only on by default, which will > error out when using an read only image. Fix it by setting the default > value when parsing opts. > > Reported-by: Edivaldo de Araujo Pereira > Signed-off-by: Fam Zheng > > --- > v2: fix backward compatibility by force read-only with cdrom. (Kevin) > > Signed-off-by: Fam Zheng > --- > blockdev.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan