From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36354)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VWjw0-0000Pa-Dx
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 05:32:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VWjvv-0007xM-B5
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 05:32:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20860)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VWjvv-0007xF-2l
	for qemu-devel@nongnu.org; Thu, 17 Oct 2013 05:31:55 -0400
Date: Thu, 17 Oct 2013 12:34:27 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131017093427.GD14596@redhat.com>
References: <1381993370-26201-1-git-send-email-akong@redhat.com>
	<20131017075847.GA10774@stefanha-thinkpad.redhat.com>
	<20131017081521.GC13975@redhat.com>
	<20131017083122.GB2658@amosk.info>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131017083122.GB2658@amosk.info>
Subject: Re: [Qemu-devel] [PATCH 0/2] fix updating of nic info
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws

On Thu, Oct 17, 2013 at 04:31:22PM +0800, Amos Kong wrote:
> On Thu, Oct 17, 2013 at 11:15:21AM +0300, Michael S. Tsirkin wrote:
> > On Thu, Oct 17, 2013 at 09:58:47AM +0200, Stefan Hajnoczi wrote:
> > > On Thu, Oct 17, 2013 at 03:02:48PM +0800, Amos Kong wrote:
> > > > I tried to change macaddr in guest, addr in guest is updated, and guest
> > > > network is fine. But the nic information in monitor isn't update. This
> > > > problem both exists in e1000 and rtl8139.
> > > > 
> > > >   1) change macaddr in guest by ifconfig
> > > >   guest)# ifconfig eth0 hw ether 12:12:12:34:35:36
> > > >   guest)# ifconfig eth0
> > > >   
> > > >   2) check network information in monitor
> > > >   (qemu) info network
> > > >   
> > > > Amos Kong (2):
> > > >   net/e1000: update network information when macaddr is changed in guest
> > > >   net/rtl8139: update network information when macaddr is changed in
> > > >     guest
> > > > 
> > > >  hw/net/e1000.c   | 8 ++++++++
> > > >  hw/net/rtl8139.c | 6 +++++-
> > > >  2 files changed, 13 insertions(+), 1 deletion(-)
> > > 
> > > Thanks, applied to my net tree:
> > > https://github.com/stefanha/qemu/commits/net
> > > 
> > > Stefan
> > 
> > Please revert, this is buggy:
> > 
> > info is changed on guest mac write but is
> > not reverted on reset.
> > 
> > Let's fix it properly, no need to introduce
> > new regressions when fixing old bugs :)
> 
> After 'system_reset' or 'reboot', nic info can't be changed until
> device init.
> 
> Updating nic info during reset is another issue, I will send patch to
> fix it.

OK so let's apply the reset change first, then these patches
on top. This way we don't break bisect.
Stefan can you rearrange pls?

> > -- 
> > MST
> 
> -- 
> 			Amos.