From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWn2m-00013M-LS for qemu-devel@nongnu.org; Thu, 17 Oct 2013 08:51:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWn2e-0004vy-9J for qemu-devel@nongnu.org; Thu, 17 Oct 2013 08:51:12 -0400 Received: from mail-bk0-x22f.google.com ([2a00:1450:4008:c01::22f]:52415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWn2e-0004vr-2A for qemu-devel@nongnu.org; Thu, 17 Oct 2013 08:51:04 -0400 Received: by mail-bk0-f47.google.com with SMTP id mx12so787160bkb.6 for ; Thu, 17 Oct 2013 05:51:03 -0700 (PDT) Date: Thu, 17 Oct 2013 14:51:01 +0200 From: Stefan Hajnoczi Message-ID: <20131017125101.GJ10774@stefanha-thinkpad.redhat.com> References: <1381803804-4551-1-git-send-email-famz@redhat.com> <525EE171.20208@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <525EE171.20208@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: kwolf@redhat.com, Fam Zheng , qemu-devel@nongnu.org, stefanha@redhat.com On Wed, Oct 16, 2013 at 08:56:49PM +0200, Max Reitz wrote: > However, this is not the reason I'd object a patch doing > something different (here: dropping the unused backing_filename > code) BTW I agree with this. This should be a separate patch. Stefan