From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWn7Z-0003r0-EZ for qemu-devel@nongnu.org; Thu, 17 Oct 2013 08:56:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWn7S-0006Ys-V5 for qemu-devel@nongnu.org; Thu, 17 Oct 2013 08:56:09 -0400 Received: from mail-bk0-x22a.google.com ([2a00:1450:4008:c01::22a]:59583) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWn7S-0006Yj-Nv for qemu-devel@nongnu.org; Thu, 17 Oct 2013 08:56:02 -0400 Received: by mail-bk0-f42.google.com with SMTP id my10so806092bkb.15 for ; Thu, 17 Oct 2013 05:56:01 -0700 (PDT) Date: Thu, 17 Oct 2013 14:55:59 +0200 From: Stefan Hajnoczi Message-ID: <20131017125559.GA17903@stefanha-thinkpad.redhat.com> References: <1381494616-1544-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381494616-1544-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block/raw-win32: Always use -errno in hdev_open List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi On Fri, Oct 11, 2013 at 02:30:16PM +0200, Max Reitz wrote: > On one occasion, hdev_open() returned -1 in case of an unknown error > instead of a proper -errno value. Adjust this to match the behavior of > raw_open() (in raw-win32), which is to return -EINVAL in this case. > Also, change the call to error_setg*() to match the one in raw_open() as > well. > > Signed-off-by: Max Reitz > --- > Follow-up to (as suggested by Eric): > - block/raw-win32: Employ error parameter > (3/5 from the "block: Employ error parameter" series) > --- > block/raw-win32.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan