From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 2/2] vmdk: Implment bdrv_get_specific_info
Date: Thu, 17 Oct 2013 15:04:33 +0200 [thread overview]
Message-ID: <20131017130433.GB17903@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1381493315-10999-3-git-send-email-famz@redhat.com>
On Fri, Oct 11, 2013 at 08:08:35PM +0800, Fam Zheng wrote:
> @@ -814,6 +821,7 @@ static int vmdk_open_desc_file(BlockDriverState *bs, int flags,
> ret = -ENOTSUP;
> goto exit;
> }
> + s->create_type = g_strdup(ct);
Where is this freed if opening the file fails?
next prev parent reply other threads:[~2013-10-17 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 12:08 [Qemu-devel] [PATCH v3 0/2] vmdk: Implement bdrv_get_specific_info Fam Zheng
2013-10-11 12:08 ` [Qemu-devel] [PATCH v3 1/2] qapi: Add optional field 'compressed' to ImageInfo Fam Zheng
2013-10-11 12:08 ` [Qemu-devel] [PATCH v3 2/2] vmdk: Implment bdrv_get_specific_info Fam Zheng
2013-10-17 13:04 ` Stefan Hajnoczi [this message]
2013-10-11 12:17 ` [Qemu-devel] [PATCH v3 0/2] vmdk: Implement bdrv_get_specific_info Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017130433.GB17903@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).