From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] vmdk: Only read cid from image file when opening
Date: Thu, 17 Oct 2013 15:25:59 +0200 [thread overview]
Message-ID: <20131017132559.GC17903@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1381478139-11003-1-git-send-email-famz@redhat.com>
On Fri, Oct 11, 2013 at 03:55:39PM +0800, Fam Zheng wrote:
> @@ -378,6 +359,22 @@ static int vmdk_parent_open(BlockDriverState *bs)
> }
>
> pstrcpy(bs->backing_file, end_name - p_name + 1, p_name);
> +
> + ret = bdrv_open_backing_file(bs, NULL, errp);
This breaks 'backing.' options since we ignore them here. I suggest
letting the block layer open the backing file as normal instead of
duplicating the code here.
Simply add a bool s->cid_checked field to remember whether the CID
needs to be checked. Then it will only be done once.
prev parent reply other threads:[~2013-10-17 13:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 7:55 [Qemu-devel] [PATCH] vmdk: Only read cid from image file when opening Fam Zheng
2013-10-17 13:25 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017132559.GC17903@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).