qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: mike <qiudayu@linux.vnet.ibm.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel@nongnu.org, aliguori@amazon.com,
	Stefan Weil <sw@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic
Date: Fri, 18 Oct 2013 11:00:44 +0200	[thread overview]
Message-ID: <20131018090044.GI9292@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <5260A2D5.5000506@linux.vnet.ibm.com>

On Fri, Oct 18, 2013 at 10:54:13AM +0800, mike wrote:
> >NACK
> >
> >I'm not going to merge this patch:
> >
> >If you terminate QEMU and launch it again the NIC gets a different MAC
> >address.  Some guest operating systems are sensitive to this - under
> For these users must use -device <nic-model>,mac=XX:XX:XX:XX:XX:XX.
> I think no body will boot up the guest, which sensitive to this,
> without mac address.
> 
> Actually, people use the command line without mac address, mean they mainly
> don't care about mac address, so give them random mac address is reasonable
> I think.
> 
> In my opinion, if we fix this, for qemu side no any issue, we both support
> mac address set or unset correctly.
> 
> What am I confuse is, *qemu supports mac address unset, why we force
> users must set the address when more than one guests*?
> This is unreasonable.
> 
> >many Linux distros the network interfaces names change due to the MAC
> >address change.  As a result firewall configuration will break and other
> >services may fail to start because they cannot find the interface.
> Agree, so this mac address should set in qemu command line as
> libvirt does :)
> >If you have multiple guests or want control over the MAC address, set it
> >explicitly using -device <nic-model>,mac=XX:XX:XX:XX:XX:XX.
> Currently, especially for developers, people mainly use qemu
> command line directly, and as qemu supports mac address
> unset, they may try the simplest command line to boot up
> lots of guests, they will confuse about why all this guest use
> the same mac address.

Your argument is weak: *you* want to avoid specifying the MAC address so
in exchange you want to *break* existing configurations and force other
people to start specifying a MAC address.

This doesn't improve anything, it will just annoy users and cause bug
reports.

Sorry that there isn't a solution that satisfies everyone, you'll have
to add a MAC address to your command-line.

Stefan

  reply	other threads:[~2013-10-18  9:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15  4:17 [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic Mike Qiu
2013-10-15  5:07 ` Stefan Weil
2013-10-15  5:57   ` mike
2013-10-15  6:05     ` Stefan Weil
2013-10-15  8:23       ` mike
2013-10-15 12:36   ` Eric Blake
2013-10-15 13:33     ` mike
2013-10-17 12:30       ` Stefan Hajnoczi
2013-10-18  2:54         ` mike
2013-10-18  9:00           ` Stefan Hajnoczi [this message]
2013-10-18  9:44             ` mike
2013-10-18 10:43               ` Stefan Hajnoczi
  -- strict thread matches above, loose matches on Subject: below --
2013-10-14  7:30 Mike Qiu
2013-10-14  7:32 ` mike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131018090044.GI9292@stefanha-thinkpad.redhat.com \
    --to=stefanha@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qiudayu@linux.vnet.ibm.com \
    --cc=stefanha@gmail.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).