From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VX6t1-0008IG-CA for qemu-devel@nongnu.org; Fri, 18 Oct 2013 06:02:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VX6sw-0007NS-J6 for qemu-devel@nongnu.org; Fri, 18 Oct 2013 06:02:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VX6sw-0007NO-A1 for qemu-devel@nongnu.org; Fri, 18 Oct 2013 06:02:22 -0400 Date: Fri, 18 Oct 2013 12:02:17 +0200 From: Stefan Hajnoczi Message-ID: <20131018100217.GJ9292@stefanha-thinkpad.redhat.com> References: <1381993370-26201-1-git-send-email-akong@redhat.com> <20131017075847.GA10774@stefanha-thinkpad.redhat.com> <20131017081521.GC13975@redhat.com> <20131017083122.GB2658@amosk.info> <20131017093427.GD14596@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131017093427.GD14596@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] fix updating of nic info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Stefan Hajnoczi , Amos Kong , qemu-devel@nongnu.org, anthony@codemonkey.ws On Thu, Oct 17, 2013 at 12:34:27PM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 17, 2013 at 04:31:22PM +0800, Amos Kong wrote: > > On Thu, Oct 17, 2013 at 11:15:21AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Oct 17, 2013 at 09:58:47AM +0200, Stefan Hajnoczi wrote: > > > > On Thu, Oct 17, 2013 at 03:02:48PM +0800, Amos Kong wrote: > > > > > I tried to change macaddr in guest, addr in guest is updated, and guest > > > > > network is fine. But the nic information in monitor isn't update. This > > > > > problem both exists in e1000 and rtl8139. > > > > > > > > > > 1) change macaddr in guest by ifconfig > > > > > guest)# ifconfig eth0 hw ether 12:12:12:34:35:36 > > > > > guest)# ifconfig eth0 > > > > > > > > > > 2) check network information in monitor > > > > > (qemu) info network > > > > > > > > > > Amos Kong (2): > > > > > net/e1000: update network information when macaddr is changed in guest > > > > > net/rtl8139: update network information when macaddr is changed in > > > > > guest > > > > > > > > > > hw/net/e1000.c | 8 ++++++++ > > > > > hw/net/rtl8139.c | 6 +++++- > > > > > 2 files changed, 13 insertions(+), 1 deletion(-) > > > > > > > > Thanks, applied to my net tree: > > > > https://github.com/stefanha/qemu/commits/net > > > > > > > > Stefan > > > > > > Please revert, this is buggy: > > > > > > info is changed on guest mac write but is > > > not reverted on reset. > > > > > > Let's fix it properly, no need to introduce > > > new regressions when fixing old bugs :) > > > > After 'system_reset' or 'reboot', nic info can't be changed until > > device init. > > > > Updating nic info during reset is another issue, I will send patch to > > fix it. > > OK so let's apply the reset change first, then these patches > on top. This way we don't break bisect. > Stefan can you rearrange pls? Yes, I will reorder the patches. Thanks for spotting this problem. Stefan