From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VX98u-0007Xn-SO for qemu-devel@nongnu.org; Fri, 18 Oct 2013 08:27:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VX98m-0005rw-F5 for qemu-devel@nongnu.org; Fri, 18 Oct 2013 08:27:00 -0400 Received: from mail-ee0-x232.google.com ([2a00:1450:4013:c00::232]:46025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VX98m-0005rj-83 for qemu-devel@nongnu.org; Fri, 18 Oct 2013 08:26:52 -0400 Received: by mail-ee0-f50.google.com with SMTP id l10so328737eei.37 for ; Fri, 18 Oct 2013 05:26:51 -0700 (PDT) Date: Fri, 18 Oct 2013 14:26:48 +0200 From: Stefan Hajnoczi Message-ID: <20131018122648.GA19041@stefanha-thinkpad.redhat.com> References: <1381233491-17019-1-git-send-email-pl@kamp.de> <1381233491-17019-17-git-send-email-pl@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381233491-17019-17-git-send-email-pl@kamp.de> Subject: Re: [Qemu-devel] [PATCHv4 16/17] qemu-img: conditionally zero out target on convert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com, ronniesahlberg@gmail.com On Tue, Oct 08, 2013 at 01:58:10PM +0200, Peter Lieven wrote: > If the target has_zero_init = 0, but supports efficiently > writing zeroes by unmapping we call bdrv_zeroize to s/bdrv_zeroize/bdrv_make_zero/ No need to respin.